Skip to content

Conversation

@pileks
Copy link

@pileks pileks commented Apr 30, 2025

This PR aims to fix the action and make it easier to work with for future upgrades.

The main reason for opening this PR is that I found that the action had trouble running, and when it did run it produced a transaction that could not complete if the IDL was added to it.

Changelog:

  • Fix proposed transaction to first update IDL, then run program upgrade
    • Otherwise, the transaction would fail
  • Pull action inputs, and only use ENV variables if action input isn't present
  • Pre-build the action executable code and make runnable through simple Node runner
  • Remove dependencies and extra patches that are not required
  • Update all dependencies to latest version
  • Clean up readme
  • Add workflow to automatically build action executable code and commit build back (in case developers forget to do so)

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedesbuild@​0.19.10 ⏵ 0.25.391100 +57192 -1100
Updated@​types/​inquirer@​9.0.3 ⏵ 9.0.71001007577100
Updatedtsx@​4.7.0 ⏵ 4.19.4100 +110080 -2092100
Updatedrimraf@​2.7.1 ⏵ 6.0.199100100 +181 +1100
Updated@​sqds/​multisig@​1.9.0 ⏵ 2.1.396 +1110097 +2583100
Updatedtypescript@​5.2.2 ⏵ 5.8.310010089100100
Updated@​solana/​web3.js@​1.78.5 ⏵ 1.98.299 +2100 +1610095100

View full report

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn High
[email protected] has a License Policy Violation.

License: CC-BY-4.0 (package/ThirdPartyNoticeText.txt)

License: MIT-Khronos-old (package/ThirdPartyNoticeText.txt)

Source: package.json

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant